gen_packets: fix crash in send_packet

Alexandra Sandulescu · Alexandra Sandulescu · commit 1c14d4b39c57 · 2020-05-18T16:58:57.000+02:00
** due to improper sanitization of ax25_from_text result, ax25_pack crashes when pp is NULL
diff --git a/gen_packets.c b/gen_packets.c
@@ -116,6 +116,12 @@ static void send_packet (char *str)
 	}
 	else {
 	  pp = ax25_from_text (str, 1);
+	  if (pp == NULL) {
+	    text_color_set(DW_COLOR_ERROR);
+	    dw_printf ("Failed to create frame from text.\n");
+	    return;
+	  }
+
 	  flen = ax25_pack (pp, fbuf);
 	  for (c=0; c<modem.adev[0].num_channels; c++)
 	  {

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,12 @@ static void send_packet (char *str)`
`116`	`116`	`}`
`117`	`117`	`else {`
`118`	`118`	`pp = ax25_from_text (str, 1);`
	`119`	`+ if (pp == NULL) {`
	`120`	`+ text_color_set(DW_COLOR_ERROR);`
	`121`	`+ dw_printf ("Failed to create frame from text.\n");`
	`122`	`+ return;`
	`123`	`+ }`
	`124`	`+`
`119`	`125`	`flen = ax25_pack (pp, fbuf);`
`120`	`126`	`for (c=0; c<modem.adev[0].num_channels; c++)`
`121`	`127`	`{`