Skip to content

Commit 8831f60

Browse files
committed
Remove some warnings that upset people and might be excessive.
1 parent 486b3cf commit 8831f60

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/xid.c

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,17 @@ int xid_parse (unsigned char *info, int info_len, struct xid_param_s *result, ch
204204
}
205205
pval = 0;
206206
for (j=0; j<plen; j++) {
207-
pval = (pval << 8) + *p++;
207+
xpected bal pval = (pval << 8) + *p++;
208208
}
209209

210210
switch (pind) {
211211

212212
case PI_Classes_of_Procedures:
213213

214214
if ( ! (pval & PV_Classes_Procedures_Balanced_ABM)) {
215-
text_color_set (DW_COLOR_ERROR);
216-
dw_printf ("XID error: Expected Balanced ABM to be set.\n");
215+
// https://groups.io/g/bpq32/topic/113348033#msg44169
216+
//text_color_set (DW_COLOR_ERROR);
217+
//dw_printf ("XID error: Expected Balanced ABM to be set.\n");
217218
}
218219

219220
if (pval & PV_Classes_Procedures_Half_Duplex && ! (pval & PV_Classes_Procedures_Full_Duplex)) {
@@ -225,8 +226,9 @@ int xid_parse (unsigned char *info, int info_len, struct xid_param_s *result, ch
225226
strlcat (desc, "Full-Duplex ", desc_size);
226227
}
227228
else {
228-
text_color_set (DW_COLOR_ERROR);
229-
dw_printf ("XID error: Expected one of Half or Full Duplex be set.\n");
229+
// https://groups.io/g/bpq32/topic/113348033#msg44169
230+
//text_color_set (DW_COLOR_ERROR);
231+
//dw_printf ("XID error: Expected one of Half or Full Duplex be set.\n");
230232
result->full_duplex = 0;
231233
}
232234

@@ -275,8 +277,9 @@ int xid_parse (unsigned char *info, int info_len, struct xid_param_s *result, ch
275277
}
276278

277279
if ( ! (pval & PV_HDLC_Optional_Functions_Extended_Address)) {
278-
text_color_set (DW_COLOR_ERROR);
279-
dw_printf ("XID error: Expected Extended Address to be set.\n");
280+
// https://groups.io/g/bpq32/topic/113348033#msg44169
281+
//text_color_set (DW_COLOR_ERROR);
282+
//dw_printf ("XID error: Expected Extended Address to be set.\n");
280283
}
281284

282285
if ( ! (pval & PV_HDLC_Optional_Functions_TEST_cmd_resp)) {

0 commit comments

Comments
 (0)