Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty callsigns in path #254

Closed
srcejon opened this issue Feb 28, 2020 · 3 comments
Closed

Empty callsigns in path #254

srcejon opened this issue Feb 28, 2020 · 3 comments

Comments

@srcejon
Copy link

srcejon commented Feb 28, 2020

Packets received from AISAT appear to have empty callsigns in the path:

[0.2] AISAT-1>CQ,,::CQ-0 :From AMSAT INDIA & Exseed Space |3264310|39|37|1070{950
APRS Message 950 for "CQ-0", Ambulance
From AMSAT INDIA & Exseed Space |3264310|39|37|1070{950
[rx>ig] AISAT-1>CQ,,,qAO,M7RCE::CQ-0 :From AMSAT INDIA & Exseed Space |3264310|39|37|1070{950

[0.2] ON4BN>CQ,AISAT*,::CQ-0 :;AISAT-1 *105428z5000.00N\00400.00WSHi all, on4bn@jubeco.be - JO21{951
APRS Message 951 for "CQ-0"
;AISAT-1 105428z5000.00N\00400.00WSHi all, on4bn@jubeco.be - JO21{951
[rx>ig] ON4BN>CQ,AISAT
,,qAO,M7RCE::CQ-0 :;AISAT-1 *105428z5000.00N\00400.00WSHi all, on4bn@jubeco.be - JO21{951

Which are then dropped by aprsc igate software, with the error: invalid callsign in path.

Is this a direwolf problem, or the a problem in the structure of the received packets from AISAT?

@srcejon
Copy link
Author

srcejon commented Feb 28, 2020

I can reproduce this by creating a packet where a via path is " ". Direwolf outputs ,, for this. Perhaps it would be better if it stripped it?

@srcejon
Copy link
Author

srcejon commented Feb 28, 2020

Attached is a possible patch to ax25_pad.c to workaround this:

ax25_pad_patch.txt

@wb2osz
Copy link
Owner

wb2osz commented Feb 28, 2020

The AISAT software was written by someone who did not understand the APRS protocol. The satellite was obviously launched without testing the APRS software first to see if it was actually compatible with the rest of the world. It has multiple problems.

Numerous software developers and countless IGate operators should not be expected to kludge the entire worldwide APRS-IS network to accommodate one faulty implementation of a simple protocol that has been around for decades. That would only encourage others to be careless and not do any testing.

Some of the discussion can be found here:

http://lists.tapr.org/pipermail/aprssig_lists.tapr.org/2019-April/047964.html
http://lists.tapr.org/pipermail/aprssig_lists.tapr.org/2019-April/047994.html
http://lists.tapr.org/pipermail/aprssig_lists.tapr.org/2019-April/047995.html
http://lists.tapr.org/pipermail/aprssig_lists.tapr.org/2019-April/047996.html
http://lists.tapr.org/pipermail/aprssig_lists.tapr.org/2019-April/047997.html

@wb2osz wb2osz closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants