Make Failure On alpine linux Arm64

[DevenBL]

This is the output of cmake .. and make consecutively
compiletime.txt
this is the master branch following these instructions:
git clone https://github.com/wb2osz/direwolf.git/
cd direwolf
mkdir build && cd build
cmake ..
make -j4
sudo make install
make install-conf

I have also tried the dev Branch but it fails on the cmake

[DevenBL]

this is the Direct output of make for convenience :
[ 1%] Building C object external/misc/CMakeFiles/misc.dir/strlcpy.c.o
[ 1%] Building C object external/geotranz/CMakeFiles/geotranz.dir/error_string.c.o
[ 1%] Building C object external/misc/CMakeFiles/misc.dir/strlcat.c.o
[ 2%] Building C object external/geotranz/CMakeFiles/geotranz.dir/mgrs.c.o
/home/devuno/Documents/direwolf/src/direwolf.h:302:56: error: expected declaration specifiers or '...' before string constant
302 | #define strlcat(dst,src,siz) strlcat_debug(dst,src,siz,FILE,func,LINE)
| ^~~~~~~~
compilation terminated due to -fmax-errors=1.
make[2]: *** [external/misc/CMakeFiles/misc.dir/build.make:76: external/misc/CMakeFiles/misc.dir/strlcpy.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/devuno/Documents/direwolf/src/direwolf.h:302:56: error: expected declaration specifiers or '...' before string constant
302 | #define strlcat(dst,src,siz) strlcat_debug(dst,src,siz,FILE,func,LINE)
| ^~~~~~~~
compilation terminated due to -fmax-errors=1.
make[2]: *** [external/misc/CMakeFiles/misc.dir/build.make:90: external/misc/CMakeFiles/misc.dir/strlcat.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:491: external/misc/CMakeFiles/misc.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 2%] Building C object external/geotranz/CMakeFiles/geotranz.dir/polarst.c.o
[ 3%] Building C object external/geotranz/CMakeFiles/geotranz.dir/tranmerc.c.o
[ 3%] Building C object external/geotranz/CMakeFiles/geotranz.dir/ups.c.o
[ 4%] Building C object external/geotranz/CMakeFiles/geotranz.dir/usng.c.o
[ 4%] Building C object external/geotranz/CMakeFiles/geotranz.dir/utm.c.o
[ 5%] Linking C static library libgeotranz.a
[ 5%] Built target geotranz
make: *** [Makefile:156: all] Error 2

[dranch]

What compiler and version are you using on your version of AlpineLinux? You also might try compiling Direwolf v1.7 from the Git "develop" branch to see if that helps.

[DevenBL]

i am using gcc 10.3.1 20210625 (Alpine 10.3.1_git20210625) there is no "develop" branch although there is a dev branch and that fails at the cmake with a cmake error regarding: No SOURCES given to target: misc

…

On Sun., Aug. 8, 2021, 12:05 a.m. David Ranch, ***@***.***> wrote: What compiler and version are you using on your version of AlpineLinux? You also might try compiling Direwolf v1.7 from the Git "develop" branch to see if that helps. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO3N5IPERK4CB67OTJYVA63T3X667ANCNFSM5BYBOR5A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[DevenBL]

this seems to be the same issue as #150
when i try to cmake on the dev branch this is the output:
-- The C compiler identification is GNU 10.3.1
-- The CXX compiler identification is GNU 10.3.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.32.0")
-- Dire Wolf Version: 1.7.0-b66c21d
-- Build type set to: Release
CMake system: Linux
-- Target architecture: ARM64
-- Use NEON SIMD instructions
-- Looking for strlcpy
-- Looking for strlcpy - found
-- Looking for strlcat
-- Looking for strlcat - found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Checking for module 'libgps'
-- Found libgps, version 3.22
-- Found GPSD: /usr/lib/libgps.so
-- Checking for module 'hamlib'
-- Found hamlib, version 4.2
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to find_package_handle_standard_args (HAMLIB)
does not match the name of the calling package (hamlib). This can lead to
problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.
Call Stack (most recent call first):
cmake/modules/Findhamlib.cmake:55 (find_package_handle_standard_args)
CMakeLists.txt:284 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.

-- Found HAMLIB: /usr/lib/libhamlib.so
-- Found ALSA: /usr/lib/libasound.so (found version "1.2.5.1")
-- Checking for module 'libudev'
-- Found libudev, version 243
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to find_package_handle_standard_args (UDEV) does
not match the name of the calling package (udev). This can lead to
problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.
Call Stack (most recent call first):
cmake/modules/Findudev.cmake:68 (find_package_handle_standard_args)
CMakeLists.txt:298 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.

-- Found UDEV: /usr/lib/libudev.so
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to find_package_handle_standard_args (AVAHI) does
not match the name of the calling package (Avahi). This can lead to
problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.
Call Stack (most recent call first):
cmake/modules/FindAvahi.cmake:12 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:303 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.

-- Found AVAHI: TRUE
-- Configuring done
CMake Error at external/misc/CMakeLists.txt:35 (add_library):
No SOURCES given to target: misc

CMake Generate step failed. Build files cannot be regenerated correctly.

[DevenBL]

this is the package list:
abuild
alpine-base
alsa-lib
alsa-lib-dev
avahi
avahi-dev
binutils
build-base
cmake
eudev
eudev-dev
eudev-libs
eudev-openrc
extra-cmake-modules
gcc
gpsd
gpsd-dev
hamlib
hamlib-dev

[dranch]

Seems there are other reports of this issue with Direwolf and it seems to be more of a Cmake on Alpine issue:

https://www.gitmemory.com/issue/wb2osz/direwolf/319/787401401

If you look at the internals of Direwolf's external/misc/CMakeLists.txt file, you see explicit mention of this issue with Alpine Linux starting at line 16:

# It seems that Alpine Linux and Void Linux have strlcpy and
# strlcat so we need to handle the situation more delicately.
# When doing it this way, there is probably no reason to
# distinguish between Linux and BSD-like systems here.
# If we kept going, the same thing could be done for each
# of the functions and no OS check would be needed.

There are hints in flann-lib/flann#369 saying that the issue is with the way Cmake is being used here but it's not 100% clear what the proper fix for Direwolf would be.

[dranch]

Seems like some hints on the fix can be found here but I cannot try a fix as I don't have Alpine LInux:

https://bugs.gentoo.org/show_bug.cgi?id=652594 is the overview and the specific example fixes for that project are here:

https://github.com/alpinelinux/aports/pull/3901/files

[DevenBL]

Seems like some hints on the fix can be found here but I cannot try a fix as I don't have Alpine LInux:

https://bugs.gentoo.org/show_bug.cgi?id=652594 is the overview and the specific example fixes for that project are here:

https://github.com/alpinelinux/aports/pull/3901/files

Alpine linux uses cmake-3.21.1-r0

this seems to explain the issue succinctly buildroot/buildroot@0c46947
it mentions "But flann CMake use a trick that use
an empty string "" as source list"
and that's probably what's at the core of this issue: flann-lib/flann#369

TLDR: Cmake changed the way add_library() works.

"With CMake >= 3.11, the new behaviour of add_library() break the
existing flann CMake code." - buildroot/buildroot@0c46947

[DevenBL]

so as per the error "CMake Error at external/misc/CMakeLists.txt:35 (add_library):
No SOURCES given to target: misc" seems like the misc target needs a source

[DevenBL]

going back to fixing the compile issue on the master branch and not the cmake issue on the Dev branch
this seems relevant:
void-linux/void-packages#27510

[DevenBL]

This is the same issue aswell #319

[DevenBL]

output.txt
For the sake of completeness i am slamming all of the output from the master branch in here this is the output of
cmake ..
make -j4
make -j4
Here is the output from the last make:
[ 1%] Building C object external/misc/CMakeFiles/misc.dir/strlcat.c.o
[ 1%] Building C object external/misc/CMakeFiles/misc.dir/strlcpy.c.o
[ 5%] Built target geotranz
/home/devuno/Documents/direwolf/src/direwolf.h:302:56: error: expected declaration specifiers or '...' before string constant
302 | #define strlcat(dst,src,siz) strlcat_debug(dst,src,siz,FILE,func,LINE)
| ^~~~~~~~
/home/devuno/Documents/direwolf/src/direwolf.h:302:56: error: expected declaration specifiers or '...' before string constant
302 | #define strlcat(dst,src,siz) strlcat_debug(dst,src,siz,FILE,func,LINE)
| ^~~~~~~~
compilation terminated due to -fmax-errors=1.
compilation terminated due to -fmax-errors=1.
make[2]: *** [external/misc/CMakeFiles/misc.dir/build.make:76: external/misc/CMakeFiles/misc.dir/strlcpy.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [external/misc/CMakeFiles/misc.dir/build.make:90: external/misc/CMakeFiles/misc.dir/strlcat.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:491: external/misc/CMakeFiles/misc.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

[makerio90]

arch. both aur options fail and manual install also fails.
x86-64

[wb2osz]

I installed Alpine Linux in a VM so I can try to get to the bottom of this.
Forgive me if I;m going back to the beginning covering the same territory again. I'm trying to understand what is going on here,
I'm using the "dev" branch which will be release 1.7.

cmake says error at external/misc/CMakeLists.txt (add_library)
No sources given to target: misc

The problem is that we are adding an empty list to add_library.
This is cmake version 3.26.5. We see some discussion above, and other Internet rumblings, about the change in functionality when the source file list is empty.

We have a similar situation with Mac OSX where the C library provides strlcpy. In my case cmake version is 3.17.0.

AHA! When we look in external/misc/CMakeLists.txt, we see there is a test for OS type. For BSD and similar, we simply assume the strl... functions are available, and have:

set(MISC_LIBRARIES "" CACHE INTERNAL "")

rather than following the Linux logic. Perhaps the solution would be to do this instead of add_library if the source file list is empty.

73,
john WB2OSZ

[wb2osz]

It should also be noted that these packages need to be installed:
linux-headers
alsa-lib-dev

This was added to the 1.7 User Guide (out soon).

[wb2osz]

I pushed a change (commit 877d1c7) that fixed the build for Alpine Linux and I thought that should be ok for other platforms.
Unfortunately it broke Ubuntu and Raspberry Pi.
We need a cmake expert to take a look at this.

[wb2osz]

I think I have something that fixes the build on Alpine without breaking the others.
Try the most recent in the "dev" branch.