direwolf will not compile with gpsd 3.23.1

[km4ack]

If gpsd 3.23.1 is installed on a raspberry pi, direwolf will not compile. I get the error:

dwgpsd.c:64:2: error: #error libgps API version might be incompatible.
#error libgps API version might be incompatible.

Without gpsd 3.23.1 installed, direwolf builds as it should. These are the steps I am taking to build direwolf:
sudo apt-get install -y libasound2-dev cmake libudev-dev
git clone https://www.github.com/wb2osz/direwolf
cd direwolf
mkdir build && cd build
cmake ..
make -j 4
sudo make install
make install-conf

[dranch]

It seems that the GPSD project (again) made a disruptive API change and are now at "major version 12". They've done this several times w/o clear reasons why they couldn't have just updated the MINOR version:

#Line 96
https://gitlab.com/gpsd/gpsd/-/blob/master/include/gps.h

Here is a patch for Direwolf to try allowing the new gpsd release. Your Direwolf function with a GPS will need to be tested to confirm things still work as expected for features like PBEACON, etc:

--- src/dwgpsd.c.orig 2021-10-25 08:17:34.183149193 -0700
+++ src/dwgpsd.c 2021-10-25 08:18:01.835491625 -0700
@@ -58,9 +58,9 @@

// An incompatibility was introduced with version 7
-// and again with 9 and again with 10.
+// and again with 9 and again with 10 and again with 11

-#if GPSD_API_MAJOR_VERSION < 5 || GPSD_API_MAJOR_VERSION > 11
+#if GPSD_API_MAJOR_VERSION < 5 || GPSD_API_MAJOR_VERSION > 12
#error libgps API version might be incompatible.
#endif

[wb2osz]

Changing that one line might allow it to compile properly but...
There have been cases where changing the line mentioned above allowed it to compile properly but it failed miserably at run time.
dwgpsd.c code is littered with conditional compilation based on the API version.
It is likely that some other change will be needed to make it run properly.

[dranch]

I'm compiling it now and will give it a try to see if the basics work

[wb2osz]

This has been fixed in the dev branch.

[yuvadm]

@wb2osz thanks for the fix, is dev stable enough to be used or should users wait for that patch to land in master?

[wb2osz]

The "dev" branch is stable and I don't know of any regressions.
Try using the "dev" branch.