Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong PID text sent to AGWPE client for I frame #366

Closed
mfncooper opened this issue Dec 16, 2021 · 1 comment
Closed

Wrong PID text sent to AGWPE client for I frame #366

mfncooper opened this issue Dec 16, 2021 · 1 comment

Comments

@mfncooper
Copy link

In the mon_desc() function in server.c, the text for the PID is correct for a UI frame but incorrect for an I frame. The latter incorrectly prefixes the PID value with '0x'.

For example:
UI frame: "pid=F0" -- correct
I frame: "pid=0xF0" -- incorrect

The comment above the function shows the correct text, per the AGWPE spec, but the code adds the '0x' prefix, such that a client expecting to parse the string per the spec fails.

The bug is here:
https://github.com/wb2osz/direwolf/blob/master/src/server.c#L1035
and the fix is simply to remove the leading '0x' in the format string.

@wb2osz
Copy link
Owner

wb2osz commented Dec 19, 2021

Fixed in 'dev' branch.

@wb2osz wb2osz closed this as completed Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants