Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages gated from APRSIS to RF are stripped off their sequence number #405

Closed
F4FXL opened this issue Jul 1, 2022 · 3 comments
Closed

Comments

@F4FXL
Copy link

F4FXL commented Jul 1, 2022

Steps to reproduce:
Send a message from an APRSIS only client to an RF only client. E.g. I used my APRSDroid to send a message to my FT2.

Expected Result:
The message goes onto RF unchanged and with its sequence number

Actual Result
The sequence number is removed from the message when going on air. This will prevent the recipient to send any ack packet because it did not get the sequence number. Additionally it will lead to unnecessary traffic as the sender ill continue sending the message as long as it does not get the ack.

See topic here : https://groups.io/g/direwolf/topic/92085159

@wb2osz
Copy link
Owner

wb2osz commented Jul 4, 2022

Thank you for providing a clear complete description including an example to demonstrate the problem.
This has been fixed in the dev branch.

@wb2osz wb2osz closed this as completed Jul 4, 2022
@wb2osz
Copy link
Owner

wb2osz commented Jan 28, 2023

commit 30869c7
Date: Mon Jul 4 02:11:55 2022 +0100

Issues 405 & 406 and other improvements in message interpretation.

This is in the "dev" branch which will become release 1.7.

@wb2osz
Copy link
Owner

wb2osz commented Jan 28, 2023

The error was introduced in the dev branch (release 1.7 development) by commit e108147 on February 25, 2022.

Those running release 1.6 or earlier not be impacted. This would affect only those who
are using the "dev" branch from between the two dates mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants