Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digipeated messages contains NUL character #406

Closed
F4FXL opened this issue Jul 1, 2022 · 4 comments
Closed

Digipeated messages contains NUL character #406

F4FXL opened this issue Jul 1, 2022 · 4 comments

Comments

@F4FXL
Copy link

F4FXL commented Jul 1, 2022

Steps to reproduce
Send a message from RF to RF using a direwolf digipeater configured as digipeater only

Expected result
Message is digipeated unchanged and reaches its recipient

Actual Result
The message is corrupted. The { character marking the beginning of the message is replaced by a NUL charachter. Generally speaking it seems like message digipeating/igating is quite broken in Direwolf 1.7 see also #405

image

@F4FXL F4FXL changed the title Digipeated messages contains NUL charachter Digipeated messages contains NUL charahter Jul 1, 2022
@F4FXL F4FXL changed the title Digipeated messages contains NUL charahter Digipeated messages contains NUL character Jul 1, 2022
@F4FXL
Copy link
Author

F4FXL commented Jul 1, 2022

It seems like the issue only occurs when igating is enabled... When igating is disabled everything seems to be ok.... Not sure though, needs confirmation. v1.6 also has the issue

F4FXL added a commit to F4FXL/direwolf that referenced this issue Jul 1, 2022
A '\0' char is inserted into p->message while looking for message number; The purpose is unclear as none of the code seem to require it.
This shall fix wb2osz#406
@wb2osz
Copy link
Owner

wb2osz commented Jul 4, 2022

Thank you for providing a clear complete description including an example to demonstrate the problem.
This has been fixed in the dev branch.

@wb2osz wb2osz closed this as completed Jul 4, 2022
@wb2osz
Copy link
Owner

wb2osz commented Jan 28, 2023

commit 30869c7
Date: Mon Jul 4 02:11:55 2022 +0100

Issues 405 & 406 and other improvements in message interpretation.

This is in the "dev" branch which will become release 1.7.

@wb2osz
Copy link
Owner

wb2osz commented Jan 28, 2023

The error was introduced in the dev branch (release 1.7 development) by commit e108147 on February 25, 2022.

Those running release 1.6 or earlier not be impacted. This would affect only those who
are using the "dev" branch from between the two dates mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants