Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified PID is ignored when sending Unproto using AGWPE #527

Closed
mfncooper opened this issue May 5, 2024 · 1 comment
Closed

Specified PID is ignored when sending Unproto using AGWPE #527

mfncooper opened this issue May 5, 2024 · 1 comment

Comments

@mfncooper
Copy link

When sending an Unproto message using AGWPE, Direwolf ignores the PID value specified in the AGWPE 'M' frame and always sets it to 0xF0 in the outgoing message. This makes it impossible to send NET/ROM routing broadcasts, which require a PID value of 0xCF, using AGWPE with Direwolf.

This is noted as a bug in the code:

https://github.com/wb2osz/direwolf/blob/dev/src/server.c#L2014

It would make sense, I think, for an invalid PID value of 0 to be converted to 0xF0, but where a valid (or non-zero) PID value is specified, it should be honored.

Unfortunately, the code further assumes that the data being sent in the Unproto message is always text, and uses ax25_from_text() to create the frame. This is not appropriate for messages such as NET/ROM routing broadcasts which contain binary data.

@wb2osz
Copy link
Owner

wb2osz commented May 6, 2024

Thank you for pointing out this issue.
This should be resolved in the "dev" branch.

@wb2osz wb2osz closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants