Symbols cleanups that changed behaviour?

[doismellburning]

Commit 89021dd has the message "Cleanups" but changes the behaviour of symbols_from_dest_or_src in a way that breaks the associated test - was the change deliberate (and the test needs updating) or accidental (and the test is correct)?

Specifically:

89021dd#diff-57618d7b5e160a906f23885f8c59d06d88a517be568cbd428366e24b58c13fe5L666-R690 wraps the fallback behaviour in a check for dti == '$'

This means that

direwolf/src/symbols.c

Lines 1003 to 1004 in 89021dd

	symbols_from_dest_or_src ('T', "W1ABC-14", "XXXXXX", &symtab, &symbol);
	if (symtab != '/' || symbol != 'k') dw_printf ("ERROR 1-6\n");

now fails because symtab and symbol are left unchanged (9 and # respectively from 1-5) - see also the 1-7 case below.

It's not clear to me which behaviour here is correct - if you can provide guidance please, I'm happy to PR a fix!

I also think it might be valuable to include the symbols test in the automated tests, but that might be a bit beyond my CMake...!