Mac build fixes #140
Merged
Mac build fixes #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the changes from pull request wb2osz#71 by schuyler from the main direwolf repo
ixdy
reviewed
Jul 16, 2018
There was a problem hiding this comment.
It might also be worth fixing this spurious warning?
diff --git a/Makefile.macosx b/Makefile.macosx
index 70af2ea..c4d2d60 100644
--- a/Makefile.macosx
+++ b/Makefile.macosx
@@ -44,7 +44,7 @@ ifeq (${DARWIN_CC},)
DARWIN_CC := $(shell which gcc)
EXTRA_CFLAGS :=
else
-EXTRA_CFLAGS := -fvectorize -fslp-vectorize -fslp-vectorize-aggressive -pthread
+EXTRA_CFLAGS := -fvectorize -fslp-vectorize -pthread
endif
# Change as required in support of the available librariesOtherwise, this does allow me to build the dev branch (and 1.5beta3) on my High Sierra (10.13) macOS machine.
@wb2osz any chance this can get merged in before the 1.5 release is cut?
| @@ -43,7 +43,7 @@ if [ $valid_flag -eq "0" ]; then | |||
|
|
|||
| prompt="Select SDK to use:" | |||
|
|
|||
| loc1=( $(find /Applications/XCode.app -type d -name "MacOSX10.*.sdk") ) | |||
| loc1=( $(find /Applications/Xcode.app -type l -name "MacOSX10.*.sdk") ) | |||
There was a problem hiding this comment.
not sure if it's worth maintaining the old behavior, but \( -type d -o -type l \) would match both directories and links.
|
(it's still a bit worrying that the first time you run |
|
Completed. This is now in the dev branch, currently 1.5 beta test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few changes I had to make in order to get Dire Wolf to build on my mac, running macOS 10.13.4
Among the changes:
MSG_NOSIGNALis not available on macOS, so I added a check for thatWith these changes I'm able to build and get a running version of Dire Wolf on my Mac. Ideally, another Mac user should take a look at these changes and verify that they work for them as well.