telem-seq.sh: Make compatible to busybox sh
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busybox's sh-implementation is differnt from the normal sh: In busybox-expr an empty string does not evaluate to int(0). Calling `expr ($SEQ +1)` with `SEQ=""` fails. This patch works around this behavior by making sure the file exists. I left the pipe for stderr around the `cat` in place to make sure I do not break any other error cases. Signed-off-by: Chris Fiege <chris@tinyhost.de>
|
pump What can I do to improve my chances to get this PR merged? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
busybox's sh-implementation is differnt from the normal sh:
In busybox-expr an empty string does not evaluate to int(0).
Calling
expr ($SEQ +1)withSEQ=""fails.This patch works around this behavior by making sure the file
exists.
I left the pipe for stderr around the
catin place to makesure I do not break any other error cases.
Signed-off-by: Chris Fiege chris@tinyhost.de