Disable color on non-tty output #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hacked this file myself. I run direwolf in a tmux session on a Raspberry Pi via SSH, which I attach and disconnect from as needed. The background coloring really screwed with that because it added a white background color only where it printed text. Just keep everything neutral, no colors by default, and add a flag to add colors (just like ls, grep, etc). Maybe parse out colors from a config file if someone wants them. |
|
We've a few members of our local club running Pi3 "powered by direwolf" 30M IGates now. |
|
Similar functionality is now in the "dev" branch and will be in release 1,6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a litany of problems that arise from attempting to parse output using other tools (such as diff to compare unit test output between revisions).