Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dwgpsd.c #255

Closed
wants to merge 1 commit into from
Closed

Update dwgpsd.c #255

wants to merge 1 commit into from

Conversation

lbartoletti
Copy link

Fix build with gpsd 3.20
It's the same issue as #196

https://gitlab.com/gpsd/gpsd/-/blob/release-3.20/gps.h#L78

@lbartoletti
Copy link
Author

Fixes #241

Some context, I update gpsd to 3.2.0 and I fix all packages which depends on it https://reviews.freebsd.org/D23920

@wb2osz
Copy link
Owner

wb2osz commented Mar 21, 2020

Did you actually try running this?
I tried the same thing and it compiled fine with gpsd 3.2.0 but did not work properly. Messages were not being received from the daemon. I didn't want to release the code change without seeing it work properly first.
I also noticed this in the gps.h revision history:
* mark altitude in gps_fix_t as deprecated and undefined
This seems to mean that more conditional compilation would be needed to use the "altitude" field for for API versions < 9 and some other field (probably altHAE) for API >= 9.
I wasted a lot of time on this about a month ago, got frustrated, and gave up.

@wb2osz
Copy link
Owner

wb2osz commented Mar 21, 2020

This is not the same as issue #196.
That was libgps changing the number of arguments for one of the most important functions going from API 6 to 7.

@wb2osz
Copy link
Owner

wb2osz commented Nov 8, 2020

Thanks for pointing that out.
Keeping up with all the libgps incompatible API changes is a never ending chore.
Dealing with API 9 was a little more complicated than changing one line.
This should be OK in the recent release 1.6.

@wb2osz wb2osz closed this Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants