decode_aprs.c: Limit __compar_fn_t to Linux #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX does not define __compar_fn_t. Rather than using it, except on a list systems where it does not exist, invert the conditional so that it is used when it is known to exist, and on other systems -- including unknown systems -- use a POSIX-compatible invocation. Probably switching on __linux__ isn't really right, and instead there should be a feature test in cmake. Alternatively, since passing tocall_cmp without a cast doesn't result in warning, because it is the same type except static, it would be simpler to just drop the use of __compar_fn_t entirely.
|
Resolves #369 |
|
Thanks helping to improve the product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX does not define __compar_fn_t. Rather than using it, except on
a list of systems where it does not exist, invert the conditional so that
it is used when it is known to exist, and on other systems --
including unknown systems -- use a POSIX-compatible invocation.
Probably switching on linux isn't really right, and instead there
should be a feature test in cmake. Alternatively, since passing
tocall_cmp without a cast doesn't result in warning, because it is the
same type except static, it would be simpler to just drop the use of
__compar_fn_t entirely.