Do not overwrite existing CFLAGS and LDFLAGS #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it out. No problems with compiling on Fedora 23 |
wb2osz
added a commit
that referenced
this pull request
Jan 22, 2017
|
This has been added to the "dev" branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In your Makefile.linux you overwrite the compiler flags that are currently set in the build environment. This disables a number of hardening options that are set in the Debian build environment by default, causing errors to be thrown when checking the resulting binaries.
These changes include the existing CFLAGS and LDFLAGS and append options to them, instead of just overwriting them.
Thanks,
Iain.