Restore terminal background colour on quit #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 21, 2022 18:54
NOTE: Standard output from Direwolf is not affected.
ew1abz
reviewed
Jul 7, 2022
| @@ -221,6 +221,7 @@ int main (int argc, char *argv[]) | |||
|
|
|||
| if (num_clients < 1 || num_clients > MAX_CLIENTS) { | |||
| printf ("Specify up to %d TNCs on the command line.\n", MAX_CLIENTS); | |||
| dw_printf ("\e[0m\e\n\e[0J\e"); | |||
There was a problem hiding this comment.
It seems like dw_printf ("\e[0m\e\n\e[0J\e"); always goes with exit (x);
Consider to combine those two. It might look like:
// Exit from DW and restore terminal color
void dw_exit(int exit_code)
{
dw_printf ("\e[0m\e\n\e[0J\e");
exit (exit_code);
}
dw_exit(1);
|
Extremely useful improvement! Thanks a lot! @natem-nvsd You can squash your five commits into just one. It'll make Git history cleaner and review easier. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background colour of the user's terminal is restored on quit, but Direwolf output is unaffected. The following screenshot shows the changes made.
