-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compilation on musl #394
Conversation
I have a simpler solution to the first part. Simply use:
gcc does not complain about the missing type cast. Don't recall why I put it in there. |
cmake tests whether the runtime library contains strlcpy and strlcat. To be continued... |
updated to address the first comment.
I couldn't find this in any of the cmake files. Can you point it out to me? |
The "dev" development branch already has this in direwolf.h #ifndef HAVE_STRLCPY // Need to supply our own. Were you using the "master" branch? |
yes I was basing the PR on master. so that change won't be needed? |
this should allow for compilation on musl libc possibly fixes wb2osz#150
Try the "dev" branch. |
Oops. I meant merge to master. Need to be more careful about terminology. |
Ok I see you've pulled in the change to dev in 59288b7, I'll close this now |
Thanks for helping to make this more portable. |
No problem! I'm trying to get direwolf accepted into void linux's repositories in void-linux/void-packages#37147 |
this should allow for compilation on musl libc
possibly fixes #150