Skip to content

Fix make package #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix make package #460

wants to merge 1 commit into from

Conversation

dforsi
Copy link
Contributor

@dforsi dforsi commented Apr 1, 2023

This PR allows the execution of make package as an ordinary user and prevents the overwriting of a system file.

@dforsi
Fix make package
ade596e 
Fixes:
CPack: Create package using ZIP
CPack: Install projects
CPack: - Run preinstall target for: direwolf
CPack: - Install project: direwolf []
CMake Error at .../build/conf/cmake_install.cmake:54 (file):
  file INSTALL cannot copy file
  ".../conf/99-direwolf-cmedia.rules"
  to "/etc/udev/rules.d/99-direwolf-cmedia.rules": Permission denied.
Call Stack (most recent call first):
  .../build/cmake_install.cmake:74 (include)

CPack Error: Error when generating package: direwolf
make: *** [Makefile:71: package] Errore 1
Pandapip1
Pandapip1 approved these changes Mar 17, 2025
View reviewed changes
Copy link

@Pandapip1 Pandapip1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this builds fine. This is also generally useful for overriding INSTALL_UDEV_DIR for e.g. distro packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dforsi @Pandapip1