Add retry to Hamlib rig_open call #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rig_open call. If the rig_open continues to fail after 5 tries, exit.
|
Thank you for diagnosing this problem and providing a solution. |
bjpetit
added a commit
to bjpetit/direwolf
that referenced
this pull request
Jul 13, 2024
…#484) rig_open call. If the rig_open continues to fail after 5 tries, exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few instances where the rigctld process will have started, but the socket isn't open yet. In my systemd setup, which ensures rigctld is started before direwolf starts, direwolf can start and try to call rig_open and get a connection refused error. If the rig_open is tried a few seconds later, the connection opens just fine.
This change adds a retry loop which tries up to 5 times to run rig_open. If the call fails the 5 time, direwolf will exit.