Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to no color for output #495

Closed
wants to merge 1 commit into from

Conversation

sarcasticadmin
Copy link

Description

Fixes: #494

I do not have access to a windows environment so I cannot test the windows portion of this change.

Tests

  • By default direwolf no longer outputs in color on Linux

@sarcasticadmin sarcasticadmin changed the base branch from master to dev October 30, 2023 01:08
@wb2osz
Copy link
Owner

wb2osz commented Nov 6, 2023

Thank you for your suggestion.
IMHO, seeing different types of information in different colors helps to understand it easier at a glance.
There are a few who would a black background, rather than white, but that is a different issue, and in the queue.
Changing the default would contradict all the documentation, numerous articles, Youtube content, and confuse thousands of users.
It is trivial to disable text color with "-t 0".
It is also disabled when the output is redirected to some destination other than a console device.
For reasons, I have reject this suggestion.

@wb2osz wb2osz closed this Nov 6, 2023
@sarcasticadmin
Copy link
Author

@wb2osz thank you for the explanation and consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaulting to no color for output
2 participants