Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.c to add "*" after callsign of digipeater with h bit set to show in connected AGW clients #530

Closed
wants to merge 1 commit into from

Conversation

DL7NDR
Copy link

@DL7NDR DL7NDR commented May 26, 2024

The packet 'Fm DL7NDR To CQ Via RS0ISS*' received by SoundModem is sent to a connected AGW client as 'Fm DL7NDR To CQ Via RS0ISS*'.

Direwolf whereas sends this packet to a connected AGW client as 'Fm DL7NDR To CQ Via RS0ISS' (without "*").

@komacke
Copy link

komacke commented Sep 2, 2024

I can confirm this works. Using the paracon client (https://github.com/mfncooper/paracon) it did not have the asterisk on the released direwolf. Building DL7NDR's patch causes the asterisk to show up in paracon in 2 different locations - the first digipeater and the 3rd digipeater in my path.

Setting a single digipeater causes the asterisk to show up in paracon on the sole digipeater.

It would be great to see this in the next release.

@wb2osz
Copy link
Owner

wb2osz commented Sep 13, 2024

Please try the "dev" branch and tell me whether it has the desired behavior.

73,
John WB2OSZ

@komacke
Copy link

komacke commented Sep 13, 2024

Not quite. What it seems to do is put an asterisk after the received digi and all the digis before it. For example a received path when receiving from the third digi looks like this:

via WOODY*,KBETH*,KJOHN*,KBULN,KBERR
whereas it should look like this:
via WOODY,KBETH,KJOHN*,KBULN,KBERR

EDIT:
I see your comment on the issue. It seems that this is the intended behavior in which case it works. It's certainly usable but just a little strange. But my experience is with TNC2, hence the different expected behavior.

Thanks!

@wb2osz
Copy link
Owner

wb2osz commented Sep 13, 2024

Try again.

@komacke
Copy link

komacke commented Sep 13, 2024

That's perfect! In the unproto path I can receive the first and third digis. Upon sending a "test" I received these two:
WOODY*,KBETH,KJOHN,KBULN,KBERR
WOODY,KBETH,KJOHN*,KBULN,KBERR

This is as expected. FWIW I was monitoring via paracon as mentioned previously.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants