Fix deviceid test when model present but no vendor #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes small bug introduced in b26c5a4 Without this, the error message was appended to, and e.g. `device` could end up as "UNKNOWN vendor/modelAFilterX" instead of the expected "AFilterX"
|
Fixes #577 |
doismellburning
added a commit
to doismellburning/samoyed
that referenced
this pull request
Jul 16, 2025
Per wb2osz/direwolf#577 and wb2osz/direwolf#578, looks like a small bug with error message logic was introduced in b26c5a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small bug introduced in b26c5a4
Without this, the error message was appended to, and e.g.
devicecould end up as "UNKNOWN vendor/modelAFilterX" instead of the expected "AFilterX"