Skip to content

Conversation

mfncooper
Copy link

The base filename for the check-modem300 test was missing, probably due to a copy / paste error, causing the test to be skipped when GitHub ran its build / test action.

@wb2osz
Copy link
Owner

wb2osz commented Aug 12, 2025

Thanks for finding this.
Why did it work for Linux but not Windows?

@wb2osz wb2osz merged commit 03305c7 into wb2osz:dev Aug 12, 2025
7 of 8 checks passed
@mfncooper
Copy link
Author

Thanks for merging.

The reason it worked on Linux and Mac is because CUSTOM_SCRIPT_SUFFIX is an empty string on those platforms, which meant that the output value for configure_file(), with a missing file name, was actually a directory rather than a file name. Since we preserve the file name in the copy, the result was correct, even if by accident. On Windows, CUSTOM_SCRIPT_SUFFIX is ".bat", so configure_file() was copying the script to a file named ".bat", instead of "check-modem300.bat". Later, in add_test(), the correct file name was being used, and that file did not exist because of the incorrect ".bat" target of configure_file().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants