Remove duplicate (likely incorrect) morse definition for '-' #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Morse table contains two conflicting definitions for '-':
1. "-...-" on L101 (henceforth "3dit")
2. "-....-" on L108 ("4dit")
The order of the list meant that 3dit was used as it came first.
However it also used 3dit for `=` (L107).
Multiple sources, most notably the International Telecommunication Union
Recommendation for Morse code (ITU-R;
https://www.itu.int/dms_pubrec/itu-r/rec/m/R-REC-M.1677-1-200910-I!!PDF-E.pdf),
use 4dit for `-`, and I found nobody else using 3dit.
As such, especially given the conflicting definitions, I think 3dit is
an error, and this commit removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Morse table contains two conflicting definitions for '-':
The order of the list meant that 3dit was used as it came first. However it also used 3dit for
=(L107).Multiple sources, most notably the International Telecommunication Union Recommendation for Morse code (ITU-R;
https://www.itu.int/dms_pubrec/itu-r/rec/m/R-REC-M.1677-1-200910-I!!PDF-E.pdf), use 4dit for
-, and I found nobody else using 3dit.As such, especially given the conflicting definitions, I think 3dit is an error, and this commit removes it.