Add new CMake option to build without DNS-SD #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On startup, Direwolf states that it includes optional support for dns-sd. However, no option is provided in the build to exclude such support. This means that on Linux, for example, the Avahi libraries are always required. This change adds a CMake option to exclude DNS-SD support, for both Linux and Mac builds. The default is to include it, retaining the current status. To exclude it, '-DOPTIONAL_DNSSD=OFF' can be added to the invocation of CMake. Fixes wb2osz#451
wb2osz
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, Direwolf states that it includes optional support for dns-sd. However, no option is provided in the build to exclude such support. This means that on Linux, for example, the Avahi libraries are always required.
This change adds a CMake option to exclude DNS-SD support, for both Linux and Mac builds. The default is to include it, retaining the current status. To exclude it, '-DOPTIONAL_DNSSD=OFF' can be added to the invocation of CMake.
Fixes #451